-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin edit campaign applications mock data #1876
Merged
sashko9807
merged 4 commits into
podkrepi-bg:master
from
gparlakov:admin-edit-campaign-applications-mock-data
Jul 10, 2024
Merged
Admin edit campaign applications mock data #1876
sashko9807
merged 4 commits into
podkrepi-bg:master
from
gparlakov:admin-edit-campaign-applications-mock-data
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to enable vscode users to just open the dev container and have them be ready to go in minutes - the config follows https://github.com/podkrepi-bg/dev-containers/blob/main/nodejs/README.md - and pushes to the next version 1.2.0 which fixes the vscode unsupported alpine image error
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
Allows running the tests workflows for forked repos
label
Jul 9, 2024
github-actions
bot
removed
the
run tests
Allows running the tests workflows for forked repos
label
Jul 9, 2024
sashko9807
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you put the devcontainer in different PR from this one, as it isn't really related to what this PR accomplishes.
Yes
…On Tue, Jul 9, 2024, 12:34 PM Aleksandar Petkov ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Would you put the devcontainer in different PR from this one, as it isn't
really related to what this PR accomplishes.
—
Reply to this email directly, view it on GitHub
<#1876 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2SEVY5QETQXG3D4FC7UR3ZLOVBXAVCNFSM6AAAAABKNVVMSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRVGY4DCNBUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
- add admin list of campaign applications (initial draft) - add admin only edit for campaign application (change status, external URL) - goal is to show the UI/UX to team and get early feedback
gparlakov
force-pushed
the
admin-edit-campaign-applications-mock-data
branch
from
July 9, 2024 13:00
db25346
to
fb37441
Compare
sashko9807
added
the
run tests
Allows running the tests workflows for forked repos
label
Jul 10, 2024
github-actions
bot
removed
the
run tests
Allows running the tests workflows for forked repos
label
Jul 10, 2024
sashko9807
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1842
Motivation and context
Show admin campaign applications panel with mock data to get some early feedback from team
Screenshots:
Testing
Login as admin and visit Campaign Applications