Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification subscription button on My Account (Mobile) #1783

Closed
ani-kalpachka opened this issue May 17, 2024 · 0 comments · Fixed by #1817
Closed

Fix notification subscription button on My Account (Mobile) #1783

ani-kalpachka opened this issue May 17, 2024 · 0 comments · Fixed by #1817
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@ani-kalpachka
Copy link
Member

ani-kalpachka commented May 17, 2024 •
edited
Loading

Which area(s) of Podkrepi.bg are affected?

My Account (Mobile)

Describe the Bug

The 'Activate' button for notification subscription is overlapping with another elements on mobile devices:

image

The whole component is not responsive.

To Reproduce

  1. Sign in.
  2. Go to https://podkrepi.bg/profile/my-notifications
  3. Observe the Subscription block.

Expected Behavior

The button needs to be clickable and fully visible. The Subscription block is expected to be responsive for all devices.
@ani-kalpachka ani-kalpachka added type: bug Something isn't working good first issue Good for newcomers labels May 17, 2024
iliyan90 added a commit to iliyan90/frontend that referenced this issue May 27, 2024
@iliyan90
Fix notification subscription button on My Account (Mobile) podkrepi-…
c3590f1 
…bg#1783
@iliyan90 iliyan90 mentioned this issue May 27, 2024
Merged
@sashko9807 sashko9807 linked a pull request May 27, 2024 that will close this issue
Fix notification subscription button on My Account (Mobile) #1783 #1817
Merged
ani-kalpachka pushed a commit that referenced this issue May 29, 2024
@iliyan90
Remove unnecessary horizontal line on FAQ #1818 (#1819)
128dd2f 
* Fix notification subscription button on My Account (Mobile) #1783

* Test

* fix misplaced

* Strange line on faq page #1818

* formated Strange line on faq page #1818

* yarn format lint issue#1818
ani-kalpachka pushed a commit that referenced this issue May 30, 2024
@iliyan90
Fix notification subscription button on My Account (Mobile) #1783 (#1817
e3285d1 
)

* Fix notification subscription button on My Account (Mobile) #1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Jun 19, 2024
@iliyan90 @gparlakov
Remove unnecessary horizontal line on FAQ podkrepi-bg#1818 (podkrepi-…
c135fb5 
…bg#1819)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* Strange line on faq page podkrepi-bg#1818

* formated Strange line on faq page podkrepi-bg#1818

* yarn format lint issue#1818
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Jun 19, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
91bfc08 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Jul 5, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
bcbeac0 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
sashko9807 pushed a commit that referenced this issue Jul 10, 2024
@gparlakov @iliyan90
Admin edit campaign applications mock data (#1876)
a795eba 
* chore: add devcontainer.json

- to enable vscode users to just open the dev container and have them be ready to go in minutes
- the config follows https://github.com/podkrepi-bg/dev-containers/blob/main/nodejs/README.md
- and pushes to the next version 1.2.0 which fixes the vscode unsupported alpine image error

* Fix notification subscription button on My Account (Mobile) #1783 (#1817)

* Fix notification subscription button on My Account (Mobile) #1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx

* fix: admin edit with mock data

- add admin list of campaign applications (initial draft)
- add admin only edit for campaign application (change status, external URL)
- goal is to show the UI/UX to team and get early feedback

* chore: remove irrelevant file change

---------

Co-authored-by: iliyan90 <[email protected]>
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Aug 9, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
90ccb0e 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Aug 9, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
8bd65d5 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Sep 3, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
ddddce8 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Sep 28, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
c813e68 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this issue Oct 20, 2024
@iliyan90 @gparlakov
Fix notification subscription button on My Account (Mobile) podkrepi-…
bed269a 
…bg#1783 (podkrepi-bg#1817)

* Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783

* Test

* fix misplaced

* formated with yarn lint fixed issue#1783

* yarn lint format issue1783

* remove theme from Footer.styled.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix notification subscription button on My Account (Mobile) #1783 iliyan90/frontend
1 participant
@ani-kalpachka