1638 - remove disabled filters on the campaign list page #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitur2204
added
the
run tests
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
dimitur2204
added
the
run tests
github-actions
bot
removed
the
run tests
dimitur2204
added
the
run tests
github-actions
bot
removed
the
run tests
dimitur2204
added
the
run tests
github-actions
bot
removed
the
run tests
dimitur2204
added
the
run tests
github-actions
bot
removed
the
run tests
quantum-grit
suggested changes
Nov 1, 2023
ani-kalpachka
approved these changes
Nov 8, 2023
|
Closing the pull request based on the last discussions. If a different decision is made in the future we can use these changes for removing the inactive filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1638
Motivation and context
aria-selectedto the currently selected filter and styles based on that.Screenshots:
Testing
Steps to test
Go to the
/campaignspage and see the selected "All" category and the removed empty categories. Click around to filter and see the changes.Affected urls
/campaigns