Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Campaigns] Group Filter by Categories #1638

Closed
swolf86 opened this issue Oct 28, 2023 · 5 comments
Closed

[Campaigns] Group Filter by Categories #1638

swolf86 opened this issue Oct 28, 2023 · 5 comments
Assignees
Labels
status: needs discussion when requirement is not clear or not ready for implementation status: on hold No action is expected with this label type: enhancement New feature or request

Comments

@swolf86
Copy link

swolf86 commented Oct 28, 2023

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)

No response

Describe the feature you'd like to request

Please remove/hide inactive categories.

image

Describe the solution you'd like

Please indicate that all campaigns is selected

Describe alternatives you've considered

No response

@swolf86 swolf86 added the type: enhancement New feature or request label Oct 28, 2023
@dimitur2204
Copy link
Contributor

Is this what you mean @swolf86
image

@swolf86
Copy link
Author

swolf86 commented Oct 29, 2023

@dimitur2204 yes

@igoychev
Copy link
Contributor

Some feedback, now that I see the implementation:
With less categories it feels as if the list is incomplete, because there is nothing left to indicates there might be other possible categories.

I am not aware of the initial reason for the change, but please consider alternatives like:

  • If the reason was to save space, then may be icons can be made smaller.
  • If the reason was for current categories to not feel as disabled (being grey) - let's make them in active(clickable) color, the underlining/bolding could indicate well the selected one

@swolf86 @dimitur2204
Of course, if you still want to go with not showing all categories, then let's please at least center them.

@swolf86
Copy link
Author

swolf86 commented Oct 30, 2023

Inactive categories should not be presented to the user. With many categories we create false impression we have many cayegories. To facilitate choise let show just active categories. We can align them in the middle. Let me see how it can work.
I think we have social campaigns too

Initiation of the task From Luctat UX audits and @MartinaMitz

@igoychev igoychev changed the title Categories campaigns sorting out [Campaigns] Group Filter by Categories Nov 15, 2023
@igoychev igoychev added status: needs discussion when requirement is not clear or not ready for implementation status: on hold No action is expected with this label labels Nov 15, 2023
@ani-kalpachka
Copy link
Member

I am closing the issue and the pull request based on the last discussions and the vote of the team.
If a different decision is made in the future, we can use the code provided here: #1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion when requirement is not clear or not ready for implementation status: on hold No action is expected with this label type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants