Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom icons on Accordion control #1051

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

Abderahman88
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? mentioned in #1033

What's in this Pull Request?

  • Ability to change the icons when accordion is collapsed/expanded

accordionCustomIcons

@joelfmrodrigues
Copy link
Collaborator

@Abderahman88 thanks for the PR 🙂 there is no need to change changelog or release-notes and they are creating conflicts. Can you please exclude those from the PR?
Let me know if you need any help with this.

@Abderahman88
Copy link
Contributor Author

@joelfmrodrigues Check now? The change for the changelog/release-notes was due to a git merge.

@joelfmrodrigues joelfmrodrigues merged commit fa7232f into pnp:dev Nov 18, 2021
@joelfmrodrigues
Copy link
Collaborator

@Abderahman88 many thanks, this has now been merged. Sorry for the delay.
Will be available in the next release and also in the next beta version that should be published in a few minutes

@joelfmrodrigues joelfmrodrigues added this to the 3.5.0 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants