Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion doesn't have any props to change default chevron icon #1033

Closed
pineaulo opened this issue Oct 5, 2021 · 5 comments
Closed

Accordion doesn't have any props to change default chevron icon #1033

pineaulo opened this issue Oct 5, 2021 · 5 comments
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@pineaulo
Copy link

pineaulo commented Oct 5, 2021

Category

[x] Enhancement
[ ] Bug
[ ] Question

Version

Please specify what version of the library you are using: [3.3.0]

Expected / Desired Behavior / Question

It would be very handy to have a prop that allow to define custom icon for the chevron.

@ghost
Copy link

ghost commented Oct 5, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Oct 5, 2021
@Abderahman88
Copy link
Contributor

Hi @pineaulo

The icons are fixed in the code.

/**
 * Icon styles. Feel free to change them
 */
const collapsedIcon: IIconProps = { iconName: 'ChevronRight', className: styles.accordionChevron };
const expandedIcon: IIconProps = { iconName: 'ChevronDown', className: styles.accordionChevron };

I will make a pull request to add this as a property. Stay tuned 📺

@Abderahman88
Copy link
Contributor

Almost there...

image

@AJIXuMuK Can you assign to me ?

@AJIXuMuK AJIXuMuK added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed Needs: Triage 🔍 labels Oct 25, 2021
@AJIXuMuK
Copy link
Collaborator

@Abderahman88 - done! Thanks for the help!

@joelfmrodrigues
Copy link
Collaborator

@pineaulo this change has been merged and will be available in the next release. It is also available in the latest beta release.

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Nov 18, 2021
@joelfmrodrigues joelfmrodrigues added this to the 3.5.0 milestone Nov 18, 2021
@AJIXuMuK AJIXuMuK closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

4 participants