Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong ConfigureAwait usage. #824

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Fixed wrong ConfigureAwait usage. #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sdk/PnP.Core/Model/Base/DataModelExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal static async Task EnsureParentObjectAsync(this IDataModelParent model)
await gettableParent.LoadBatchAsync(ensureParentBatch, expressions).ConfigureAwait(false);

// Make the actual request
await contextAwareParent.PnPContext.BatchClient.ExecuteBatch(ensureParentBatch).ConfigureAwait(true);
await contextAwareParent.PnPContext.BatchClient.ExecuteBatch(ensureParentBatch).ConfigureAwait(false);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/sdk/PnP.Core/Model/SharePoint/Pages/Internal/Page.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ private async Task ValidateOneColumnFullWidthSectionUsageAsync()
}
if (hasOneColumnFullWidthSection)
{
await PnPContext.Web.EnsurePropertiesAsync(p => p.WebTemplate).ConfigureAwait(true);
await PnPContext.Web.EnsurePropertiesAsync(p => p.WebTemplate).ConfigureAwait(false);
if (!PnPContext.Web.WebTemplate.Equals("SITEPAGEPUBLISHING", StringComparison.InvariantCultureIgnoreCase) &&
// we allow enabling communication site features on STS and EHS sites, so don't block adding full width sections on those sites
!PnPContext.Web.WebTemplate.Equals("STS", StringComparison.InvariantCultureIgnoreCase) &&
Expand Down
4 changes: 2 additions & 2 deletions src/sdk/PnP.Core/Services/Core/Query/TokenHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static async Task<string> ResolveTokensAsync(IMetadataExtensible pnpObjec
// Ensure the parent object
if (parent != null)
{
await ((IDataModelParent)pnpObject).EnsureParentObjectAsync().ConfigureAwait(true);
await ((IDataModelParent)pnpObject).EnsureParentObjectAsync().ConfigureAwait(false);
}

if (parent is IMetadataExtensible p)
Expand Down Expand Up @@ -94,7 +94,7 @@ public static async Task<string> ResolveTokensAsync(IMetadataExtensible pnpObjec
// Ensure the parent object
if (parent != null)
{
await ((IDataModelParent)pnpObject).EnsureParentObjectAsync().ConfigureAwait(true);
await ((IDataModelParent)pnpObject).EnsureParentObjectAsync().ConfigureAwait(false);
}

if (parent is IMetadataExtensible p)
Expand Down