Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong ConfigureAwait usage. #824

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

s-KaiNet
Copy link
Collaborator

The title is quite self-explanatory. ConfigureAwait(true) doesn't make sense, because it's default behaviour, in "library" projects we should always use ConfigureAwait(false). I believe true that was added by mistake.

@codecov-commenter
Copy link

Codecov Report

Merging #824 (8f02798) into dev (63545f3) will increase coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #824      +/-   ##
==========================================
+ Coverage   82.42%   83.45%   +1.03%     
==========================================
  Files         416      479      +63     
  Lines       28590    33354    +4764     
==========================================
+ Hits        23565    27837    +4272     
- Misses       5025     5517     +492     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
....Core/Exceptions/MicrosoftGraphServiceException.cs 80.00% <0.00%> (-20.00%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 87.67% <0.00%> (-12.33%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
...e/Model/SharePoint/Core/Internal/ListCollection.cs 82.12% <0.00%> (-9.09%) ⬇️
...P.Core/Services/Core/CSOM/Utils/CSOMFieldHelper.cs 80.61% <0.00%> (-7.81%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94aa95...8f02798. Read the comment docs.

@jansenbe jansenbe self-assigned this Apr 19, 2022
@jansenbe jansenbe merged commit e19662c into pnp:dev Apr 19, 2022
jansenbe added a commit that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants