Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(erc20-on-int): pass through origin tx info #23

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

ubordignon
Copy link
Contributor

The other side of #18.

@ubordignon ubordignon requested a review from gskapka March 1, 2024 15:50
@gskapka gskapka changed the title Erc20 on int pass through origin tx info erc20-on-int pass through origin tx info Mar 4, 2024
Copy link
Contributor

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to rebase this since the underlying PR has some changes too. Then, once that's merged (likely later today) you'll want to rebase this on master.

Otherwise, couple of changes required, which changes I've also done on my PR so you can blame me. See inline comments.

scripts/test-build-with-origin-tx-details.sh Show resolved Hide resolved
v2_bridges/erc20_on_int/Cargo.toml Outdated Show resolved Hide resolved
v2_bridges/erc20_on_int/src/int/eth_tx_info.rs Outdated Show resolved Hide resolved
v2_bridges/erc20_on_int/src/int/metadata.rs Show resolved Hide resolved
v2_bridges/erc20_on_int/src/int/metadata.rs Outdated Show resolved Hide resolved
@ubordignon ubordignon force-pushed the erc20-on-int-pass-through-origin-tx-info branch from 2bb2111 to 8f448bb Compare March 4, 2024 15:34
@ubordignon
Copy link
Contributor Author

Ready for a second pass!

@ubordignon ubordignon force-pushed the erc20-on-int-pass-through-origin-tx-info branch 4 times, most recently from ccd1c0f to 271187a Compare March 6, 2024 16:21
@gskapka gskapka changed the title erc20-on-int pass through origin tx info feat(erc20-on-int) pass through origin tx info Mar 11, 2024
@ubordignon ubordignon force-pushed the erc20-on-int-pass-through-origin-tx-info branch from 271187a to bb9d201 Compare March 11, 2024 15:36
@ubordignon ubordignon changed the title feat(erc20-on-int) pass through origin tx info feat(erc20-on-int): pass through origin tx info Mar 11, 2024
@gskapka gskapka merged commit 08080b7 into master Mar 12, 2024
5 checks passed
@gskapka gskapka deleted the erc20-on-int-pass-through-origin-tx-info branch March 12, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants