feat(int-on-evm): pass through originating tx info in that #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if feature enabled
|
This is currently blocked due to the requirement that we get origin details even in the case of host-to-host transfers. This in turn requires a change to the router contract in the interim chain to fire a custom event from which to parse these details. |
oliviera9
reviewed
Feb 8, 2024
gskapka
force-pushed
the
pass-through-originating-tx-info
branch
from
7e7397d to
112e92d
Compare
gskapka
force-pushed
the
pass-through-originating-tx-info
branch
from
112e92d to
ac90591
Compare
gskapka
force-pushed
the
pass-through-originating-tx-info
branch
from
87fa583 to
99c5fcb
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...per title.
Feature is enabled at build time via flag
--features=include-origin-tx-details.Currently only implemented from the
intside to theevmside.❗ Note: Custom handling for
pnt-on-gnosishas been removed also.❗ Note:
Using the mint event for the originating details means we cannot get those details for host-to-host transfers.Removed.❗ Note:
New event required in router in order to preserve origin details during h2h transfers.New event implemented.❗ The gas price provisions for peg-ins and -outs has been bumped from
450_000to1_000_000as required by @oliviera9.To Do:
✅ Rebase on master once #21 is merged.
🔲 Add sample
intsubmission material which includes new router event and write test over it. (Currently unimplemented hence failing test in CI)