Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show zeroline even when no grid lines are present #4189

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Show zeroline even when no grid lines are present #4189

merged 3 commits into from
Sep 19, 2019

Commits on Sep 13, 2019

  1. replace 'showzeroline' -> 'zeroline' 

    - 'showzeroline' isn't a valid a attribute
- the tests worked fine as 'zeroline' got coerced to true
  in all the cases present.
    @etpinard
    etpinard committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    184db74 View commit details
    Browse the repository at this point in the history

  2. use ax._gridVals to built WebGL splom grid line data 

    - ... that is instead of ax._vals
- ax._gridVals has the grid line of the axis ends filtered out,
  which leads here to less rendered line - improving perf
  w/o generating a diff in the baselines.
    @etpinard
    etpinard committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    9f30e0a View commit details
    Browse the repository at this point in the history

  3. fix #4027 - show zeroline even when no grid lines are present 

    - see #4027
  for complete rationale
- add assertZeroLines assertion
    @etpinard
    etpinard committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    ed81f17 View commit details
    Browse the repository at this point in the history