Show zeroline even when no grid lines are present #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'showzeroline' isn't a valid a attribute - the tests worked fine as 'zeroline' got coerced to true in all the cases present.
- ... that is instead of ax._vals - ax._gridVals has the grid line of the axis ends filtered out, which leads here to less rendered line - improving perf w/o generating a diff in the baselines.
- see #4027 for complete rationale - add assertZeroLines assertion
|
Nicely done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4027 as proposed in #4027 (comment)
before: https://codepen.io/anon/pen/pXxqeW
after: https://codepen.io/etpinard/pen/bGbKyrx
N.B. also in this PR, commit 9f30e0a improves splom WebGL grid line generation perf
cc @archmoj