Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons on dark background #219

Closed
cherylhjli opened this issue Jan 31, 2020 · 0 comments · Fixed by #229
Closed

Buttons on dark background #219

cherylhjli opened this issue Jan 31, 2020 · 0 comments · Fixed by #229
Labels
enhancement New feature or request

Comments

@cherylhjli
Copy link

Is your feature request related to a problem? Please describe.

Currently we don't have primary and secondary buttons designed specifically for dark backgrounds.

Describe the solution you'd like

In the states table, preview here:
Screen Shot 2020-01-31 at 1 44 14 PM

Describe alternatives you've considered

Also considered using blue 200 for the primary button, and while that looks good when dark mint 500 is the background, it doesn't look as good or provide as much contrast when it's paired with blue 500, which is the dark background that's used most in the screens right now.

@cherylhjli cherylhjli added the enhancement New feature or request label Jan 31, 2020
greatislander pushed a commit that referenced this issue Feb 10, 2020
- Resolves #188.
- Resolves #189.
- Resolves #201.
- Resolves #202.
- Resolves #204.
- Resolves #208.
- Resolves #219.
- Resolves #221.
- Resolves #222.
- Resolves #223.
- Resolves #231.

Co-authored-by: jhung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant