Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new link styling for header links and CTAs #201

Closed
jhung opened this issue Jan 28, 2020 · 0 comments · Fixed by #229
Closed

Implement new link styling for header links and CTAs #201

jhung opened this issue Jan 28, 2020 · 0 comments · Fixed by #229
Assignees
@greatislander
Labels
enhancement New feature or request
Milestone
1.0.0-alpha.10

Comments

@jhung
Copy link
Contributor

jhung commented Jan 28, 2020 •
edited
Loading

Implement changes to hover and focus styles for header links and CTAs to be more consistent with the overall focus and hover design for links. This addresses part of #189.
@jhung jhung added the enhancement New feature or request label Jan 28, 2020
@jhung jhung added this to the 1.0.0-alpha.10 milestone Jan 28, 2020
@jhung jhung self-assigned this Jan 28, 2020
@greatislander greatislander mentioned this issue Jan 28, 2020
Closed
@greatislander greatislander mentioned this issue Jan 31, 2020
Merged
3 tasks
greatislander pushed a commit that referenced this issue Jan 31, 2020
feat: implement new call to action link styles (#201) (#218)
3d5f6a6 
* feat: add new external icon

* feat: implement new call to action

* feat: use new call to action in single resource view

* feat: add internal/external variants
@greatislander greatislander mentioned this issue Feb 3, 2020
Merged
27 tasks
@greatislander greatislander assigned greatislander and unassigned jhung Feb 10, 2020
greatislander pushed a commit that referenced this issue Feb 10, 2020
@jhung
feat: refactor buttons and links using custom properties (#229)
245c866 
- Resolves #188.
- Resolves #189.
- Resolves #201.
- Resolves #202.
- Resolves #204.
- Resolves #208.
- Resolves #219.
- Resolves #221.
- Resolves #222.
- Resolves #223.
- Resolves #231.

Co-authored-by: jhung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.10
Development

Successfully merging a pull request may close this issue.

feat: refactor buttons and links using custom properties platform-coop-toolkit/pinecone
2 participants
@jhung @greatislander