Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text encoding in tag labels (resolves #167) #166

Merged
merged 5 commits into from
Jan 28, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 27, 2020

Description

Ampersands were being encoded in resource topic labels on the single resource view, on resource cards, and on term lists. Links to publishers were being displayed on resource cards.

Steps to test

  1. Add a topic with an ampersand in the title.
  2. Apply it to a resource.
  3. Examine the resource card and single resource view.
  4. Examine the term list in which the topic appears.

Expected behavior: The ampersand should be displayed normally (&), not encoded (&). No publisher links appear on resource cards.

Additional information

Not applicable.

Related issues

Resolves platform-coop-toolkit/coop-library-framework#270.
@greatislander greatislander requested a review from jhung January 27, 2020 18:15
@greatislander greatislander self-assigned this Jan 27, 2020
@greatislander greatislander added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jan 27, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Jan 27, 2020
@greatislander greatislander changed the title fix: text encoding in tag labels fix: text encoding in tag labels and term lists, remove extra links from cards Jan 27, 2020
@greatislander greatislander changed the title fix: text encoding in tag labels and term lists, remove extra links from cards fix: text encoding in tag labels (resolves #167) Jan 27, 2020
@greatislander greatislander merged commit 3f3f483 into dev Jan 28, 2020
@greatislander greatislander deleted the fix/tag-label-encoding branch January 28, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ampersand glitch and Title Shortening
2 participants