Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampersand glitch and Title Shortening #167

Closed
difea451 opened this issue Jan 27, 2020 · 1 comment · Fixed by #166
Closed

Ampersand glitch and Title Shortening #167

difea451 opened this issue Jan 27, 2020 · 1 comment · Fixed by #166
Assignees
Labels
bug Something isn't working
Milestone

Comments

@difea451
Copy link

Describe the bug
glitch in tags with ampersands in them-
Also- title still long even though shortened title is provided? Or is this the full page view, and the shortened title is just for the initial resource card.

To Reproduce

Expected behavior

Screenshots
Screen Shot 2020-01-27 at 11 01 47 AM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

greatislander referenced this issue Jan 27, 2020
Resolves platform-coop-toolkit/coop-library-framework#270.
@greatislander
Copy link
Collaborator

Hi @difea451 -- this is technically an issue with the front end, so I'd ask that you hold off on further tickets about how resources are currently displayed until we complete our review. And yes, the full title is displayed on the full resource view; the short title is only used on the cards in the resource list if provided (as per the description on the dashboard: "Shorter title used in resource listings").

@greatislander greatislander self-assigned this Jan 27, 2020
@greatislander greatislander transferred this issue from platform-coop-toolkit/coop-library-framework Jan 27, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Jan 27, 2020
@greatislander greatislander added the bug Something isn't working label Jan 27, 2020
greatislander added a commit that referenced this issue Jan 28, 2020
* fix: text encoding in tag labels
* fix: address issue on cards as well
* fix: don't show publisher links on cards; fix encoding for term lists
* fix: remove CSS change
* fix: don't uppercase topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants