Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add URL helper text (resolves #311) #333

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

greatislander
Copy link
Collaborator

Description

This PR adds guidance for users indicating that URLs must include http:// or https://. Preferred to automatically adding http:// or https:// to user input as it's not possible to determine which scheme is correct (all sites support http but not all support https, and we should be directing people to https if possible—but if we automatically add https:// to URLs that may result in broken links).

Steps to test

  1. Review the resource editor UI.

Expected behavior: Observe that instructions for all URL fields specify that the URL scheme must be provided.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the enhancement New feature or request label Mar 30, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 30, 2020
@greatislander greatislander requested a review from jhung March 30, 2020 21:38
@greatislander greatislander self-assigned this Mar 30, 2020
@greatislander greatislander merged commit 0b18052 into dev Mar 31, 2020
@greatislander greatislander deleted the add/url-field-guidance branch March 31, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update URL field description text, or relax URL validation rules for resources
2 participants