Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL field description text, or relax URL validation rules for resources #311

Closed
jhung opened this issue Mar 6, 2020 · 0 comments · Fixed by #333
Closed

Update URL field description text, or relax URL validation rules for resources #311

jhung opened this issue Mar 6, 2020 · 0 comments · Fixed by #333
Labels
enhancement New feature or request
Milestone

Comments

@jhung
Copy link
Collaborator

jhung commented Mar 6, 2020

Is your feature request related to a problem? Please describe.

With the ACF URL field, it requires http:// or 'https://`, otherwise the form will not validate and an error is shown. This can be confusing as the URLs may be "valid" and the instructions do not indicate the necessary formatting.

Describe the solution you'd like

Preferred solution is to add http:// or https:// if it is missing from the input upon form submission.

Easy solution, but more of a burden for the user, is to update the description string to indicate that https:// or http:// prefix is required. The resulting error message should also display a helpful instruction as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants