Update Proposal Op #154
Merged
Update Proposal Op #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reference implementation for Proposal, enable CPU SLT * code style fix * add type prop test for invalid anchor count * add unit test * fix shapes in attribute test * temp workaround- disable maring end of boxes list * Disable CPU smoke test- spec misalignment * code style fixes * add some details to the specification * disable myriadx proposal slt * review changes, using usigned int and size_t * improve proposal op shape inference to cover dynamic too, add unit test coverage * remove unused variable in test body * remove batch size in tests where its not used * add post nms topn initialization in tests where it was missing * review comments * style fix * style fix 2 * add tests, remove unused variables, change shape inference checks * style fix * add input tensors type checks and test coverage * align input type in attribute and ngraphreader tests to match specification * fix wrong dimension in error message * proposalv4 ref impl * enable single layer and unit tests for proposalv4 ref impl * align output termination with cpu, enable cpu slt * custom slt compares to detect less-than-predicted number of boxes * custom slt compares to detect less-than-predicted number of boxes * Clarify output termination in spec * review comments * smaller input data for unit tests * add check for batch_dim being static * disable gpu slt for proposal * test data style fix * test data style fix 2 * add type section to specification * shape inference improvement * multiply expected 1st dim in tests by post_nms_topn * add checks and testcases for dynamic ranks * indentation, review comments * reduce code redundancy in ref implementation * remove comment * Fix typo in proposal1 spec * Fix typo in proposal4 spec (cherry picked from commit 210ad81)
tzerrell
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proposal reference implementation from openvino upstream.