Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resolution to resize event parameters #10775

Merged
merged 6 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rendering/renderers/shared/system/AbstractRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ type Runners = {[key in DefaultRunners]: SystemRunner} & {
/* eslint-enable max-len */
export class AbstractRenderer<
PIPES, OPTIONS extends SharedRendererOptions, CANVAS extends ICanvas = HTMLCanvasElement
> extends EventEmitter<{resize: [number, number]}>
> extends EventEmitter<{resize: [screenWidth: number, screenHeight: number, resolution: number]}>
{
/** The default options for the renderer. */
public static defaultOptions = {
Expand Down Expand Up @@ -314,7 +314,7 @@ export class AbstractRenderer<
public resize(desiredScreenWidth: number, desiredScreenHeight: number, resolution?: number): void
{
this.view.resize(desiredScreenWidth, desiredScreenHeight, resolution);
this.emit('resize', this.view.screen.width, this.view.screen.height);
this.emit('resize', this.view.screen.width, this.view.screen.height, this.view.resolution);
}

public clear(options: ClearOptions = {}): void
Expand Down
4 changes: 2 additions & 2 deletions tests/renderering/Renderer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ describe('Renderer', () =>
const spy = jest.fn();

renderer.on('resize', spy);
renderer.resize(2, 4);
renderer.resize(2, 4, 3);

expect(spy).toHaveBeenCalledTimes(1);
expect(spy).toHaveBeenCalledWith(2, 4);
expect(spy).toHaveBeenCalledWith(2, 4, 3);

renderer.destroy();
});
Expand Down
Loading