-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #4033 #4084 #4097 #4102 #4104 #4114 #4117 #4119 #4122 #4123 #4128
Merged
khanhtc1202
merged 10 commits into
release-v0.41.x
from
cherry-pick-#4033-#4084-#4097-#4102-#4104-#4114-#4117-#4119-#4122-#4123-to-release-v0.41.x
Jan 13, 2023
Merged
Cherry-pick #4033 #4084 #4097 #4102 #4104 #4114 #4117 #4119 #4122 #4123 #4128
khanhtc1202
merged 10 commits into
release-v0.41.x
from
cherry-pick-#4033-#4084-#4097-#4102-#4104-#4114-#4117-#4119-#4122-#4123-to-release-v0.41.x
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keep new line at end of file in yamlprocessor * add a new line to the EOF in case of there is no at EOF * update comment * update eventwatcher_test * consider new line at EOF on parsing kubernetes manifest * update go-yaml v1.9.8 * remove TODO because PR of go-yaml was merged * consider to handle multiple new line at EOF * remove indent vioration of tab
* fix null pointer * apply review
* add example for ecs standalone task * add example for ecs standalone task * wip * add yaml example to docs. * add example for ecs standalone task * wip * add yaml example to docs. * apply review * Update docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Khanh Tran <[email protected]>
* Add update contributions command * Update hack/gen-contributions.sh
khanhtc1202
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏
khanhtc1202
deleted the
cherry-pick-#4033-#4084-#4097-#4102-#4104-#4114-#4117-#4119-#4122-#4123-to-release-v0.41.x
branch
January 13, 2023 05:05
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherry pick of #4033 #4084 #4097 #4102 #4104 #4114 #4117 #4119 #4122 #4123.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: