Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #4033 #4084 #4097 #4102 #4104 #4114 #4117 #4119 #4122 #4123 #4128

Conversation

knanao
Copy link
Member

@knanao knanao commented Jan 13, 2023

What this PR does / why we need it:
Cherry pick of #4033 #4084 #4097 #4102 #4104 #4114 #4117 #4119 #4122 #4123.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


kurochan and others added 10 commits January 13, 2023 14:01
* Keep new line at end of file in yamlprocessor

* add a new line to the EOF in case of there is no  at EOF

* update comment

* update eventwatcher_test

* consider new line at EOF on parsing kubernetes manifest

* update go-yaml v1.9.8

* remove TODO because PR of go-yaml was merged

* consider to handle multiple new line at EOF

* remove indent vioration of tab
* fix null pointer

* apply review
* add example for ecs standalone task

* add example for ecs standalone task

* wip

* add yaml example to docs.

* add example for ecs standalone task

* wip

* add yaml example to docs.

* apply review

* Update docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md

Co-authored-by: Khanh Tran <[email protected]>

Co-authored-by: Khanh Tran <[email protected]>
* Add update contributions command

* Update hack/gen-contributions.sh
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@khanhtc1202 khanhtc1202 merged commit a7c563c into release-v0.41.x Jan 13, 2023
@khanhtc1202 khanhtc1202 deleted the cherry-pick-#4033-#4084-#4097-#4102-#4104-#4114-#4117-#4119-#4122-#4123-to-release-v0.41.x branch January 13, 2023 05:05
This was referenced Feb 7, 2023
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants