Add a pipectl command to disable an application #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-namba
requested review from
nghialv,
khanhtc1202 and
knanao
as code owners
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
kevin-namba
changed the title
khanhtc1202
changed the title
|
/cla sign |
khanhtc1202
pushed a commit
that referenced
this pull request
Jan 13, 2023
knanao
pushed a commit
that referenced
this pull request
Jan 13, 2023
khanhtc1202
added a commit
that referenced
this pull request
Jan 13, 2023
… (#4128) * Keep new line at end of file in yamlprocessor (#4033) * Keep new line at end of file in yamlprocessor * add a new line to the EOF in case of there is no at EOF * update comment * update eventwatcher_test * consider new line at EOF on parsing kubernetes manifest * update go-yaml v1.9.8 * remove TODO because PR of go-yaml was merged * consider to handle multiple new line at EOF * remove indent vioration of tab * support standalone ECS task (#4084) Fixes #2734 * Small lint fix (#4097) * fix null pointer (#4102) * fix null pointer * apply review * Add example for ecs standalone task (#4104) * add example for ecs standalone task * add example for ecs standalone task * wip * add yaml example to docs. * add example for ecs standalone task * wip * add yaml example to docs. * apply review * Update docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Khanh Tran <[email protected]> * Add update contributions command (#4114) * Add update contributions command * Update hack/gen-contributions.sh * Run update go deps (#4117) * feature: cli and grpc to disable application (#4119) * Add new line in detailsFormat to fix plan preview format (#4122) * add document how to disable (#4123) Co-authored-by: Kurochan <[email protected]> Co-authored-by: Tomoki Hori <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: kevin55156 <[email protected]> Co-authored-by: Yoshiaki Ishihara <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable disabling an application from a command line.
Users can use a new command as below
Which issue(s) this PR fixes:
Fixes #1284
Does this PR introduce a user-facing change?: