Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing a=ssrc lines for RTX/FEC #2926

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add missing a=ssrc lines for RTX/FEC #2926

merged 1 commit into from
Oct 7, 2024

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Oct 7, 2024

Pion extracts them from ssrc-group line so this didn't failed Pion<->Pion. Chrome/FireFox uses the dedicated a=ssrc lines and our Offer/Answer would break negotation

Fixes #2922

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (9d6c27f) to head (aa0d9ab).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sdp.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
- Coverage   79.01%   79.00%   -0.02%     
==========================================
  Files          89       89              
  Lines        8564     8568       +4     
==========================================
+ Hits         6767     6769       +2     
- Misses       1310     1311       +1     
- Partials      487      488       +1     
Flag Coverage Δ
go 80.55% <50.00%> (-0.02%) ⬇️
wasm 64.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pion extracts them from ssrc-group line so this didn't failed
Pion<->Pion. Chrome/FireFox uses the dedicated a=ssrc lines and our
Offer/Answer would break negotation

Fixes #2922
@Sean-Der Sean-Der merged commit 64f32d2 into master Oct 7, 2024
17 of 18 checks passed
@Sean-Der Sean-Der deleted the fix-ssrc-sdp branch October 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

WHIP WHEP example is broken
2 participants