Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use duration to match configuration parameter #842

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Use duration to match configuration parameter #842

merged 1 commit into from
Jul 24, 2019

Commits on Jul 22, 2019

  1. Use duration to match configuration parameter 

    The configuration for this timeout is `config.getNewConsumerPollTimeoutSeconds();` which is also used in `SecorKafkaMessageIterator.java:55` as such.

This was causing issues, whereby the monitor poll would quickly timeout. Instead of having inconsistent usage, this seems the simplest approach.

Note that the `.poll()` method in `org.apache.kafka.clients.consumer.KafkaConsumer` is described in milliseconds.
    @chazdnato
    chazdnato authored Jul 22, 2019
    Configuration menu
    Copy the full SHA
    43919c2 View commit details
    Browse the repository at this point in the history