-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use duration to match configuration parameter #842
Conversation
The configuration for this timeout is `config.getNewConsumerPollTimeoutSeconds();` which is also used in `SecorKafkaMessageIterator.java:55` as such. This was causing issues, whereby the monitor poll would quickly timeout. Instead of having inconsistent usage, this seems the simplest approach. Note that the `.poll()` method in `org.apache.kafka.clients.consumer.KafkaConsumer` is described in milliseconds.
Change looks straightforward to me, do you have time to look at the test failure? |
Unfortunately, it looks like this PR was submitted right around when github had an outage. Three of the tests failed with a 500 error trying to download s3cmd from github. The other failure appears to be due to the test taking too long to run. Are you able to re-run? I can submit a nonce change to re-trigger a run. |
I am rebuilding those tests now. |
I see the builds failed again, but unclear if this is due to my change or how long the build takes:
|
Actually the real error is this: [INFO] ------------------------------------------------------------------------ |
:/ Unclear how this relates to my change. Or how to get past this. |
That jar was actually in the traditional maven central: https://repo1.maven.org/maven2/org/sonatype/sisu/sisu-guice/2.1.7/ Not sure when/why travis is now using google maven central. |
Looks like this switch happened on 6/28: https://changelog.travis-ci.com/new-maven-central-mirror-is-in-use-106758 |
Sent an email to google maven admin: [email protected] to see whether they can add that artifact |
Got reply from google, probably will be fixed in a few more days:
Yep - I have a job fixing some syncs running now - it's at 10 days so far, it should finish in a few more days. I see it in the source we are syncing from. (An SSD on one of my machines) sisu-guice-2.1.7.jar sisu-guice-2.1.7-javadoc.jar sisu-guice-2.1.7-noaop.jar sisu-guice-2.1.7.pom sisu-guice-2.1.7-sources.jar Though it's a very early version, they are on 4.2.0 now. Not sure why it wasn't on the source Sonatype originally gave me, up to your mentioning it, I only knew of some checksum's missing from older archives. |
@HenryCaiHaiying Thank you! I appreciate your deep dive into this, for a simple fix! |
Looks like the google maven central issue is fixed. Now hit the second problem on 'log length is too long' on Travis-CI build, fixing this by: #847 |
All the build issues are fixed, merging this PR in. |
Thank you for all your help! |
The configuration for this timeout is
config.getNewConsumerPollTimeoutSeconds();
which is also used inSecorKafkaMessageIterator.java:55
as such.This was causing issues, whereby the monitor poll would quickly timeout. Instead of having inconsistent usage, this seems the simplest approach.
Note that the
.poll()
method inorg.apache.kafka.clients.consumer.KafkaConsumer
is described in milliseconds.