Fix indent of "by" keyword #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original fix for pinterest#1210 solved the runtime exception during formatting but also reformatted some delegate by constructs which are conflicting with the default IntelliJ formatting.
2 tasks
romtsn
reviewed
Jan 20, 2022
...nt-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/IndentationRule.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Jan 20, 2022
…ate-super-type-fix # Conflicts: # ktlint-ruleset-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/IndentationRuleTest.kt
|
pls 4 minor release kthxbye |
why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original fix for #1210 (#1305) solved the runtime exception during formatting but also reformatted some delegate by constructs which are conflicting with the defaultIntelliJ formatting.
The runtime exception is still solved. I have added an explicit assert statement after the formatting stage which break units tests that would result in a negative indent level but otherwise still woud succeed. This should protect us against similar indent problem in the future.
The new formatting introduced in #1305 is reverted.
Checklist
CHANGELOG.mdis updated