-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation of delegated super type call entry #1305
Fix indentation of delegated super type call entry #1305
Conversation
Forces the BY keyword in a super type call entry to be indented when preceded by a new line Closes pinterest#1210
Hm, when I throw this code into IJ, it actually keeps it unchanged:
Should we maybe just make sure that it doesn't fail, but follow IJ's formatting in this case? Note, however, that this case is fine:
|
You're right. We should not conflict with IntelliJ default of formatting case below:
Let me try to fix this one before merging. |
…ate-super-type # Conflicts: # CHANGELOG.md # ktlint-ruleset-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/IndentationRuleTest.kt
@paul-dingemans let me know if/when this is ready for merging. |
…ate-super-type # Conflicts: # CHANGELOG.md # ktlint-ruleset-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/IndentationRuleTest.kt
@shashachu Merge conflict is resolved. It is ready to be merged. |
@paul-dingemans but have you addressed the comment I left? the test is kinda still not looking compatible with IJ |
@romtsn @shashachu I am sorry. I only focussed at the merge conflict. I did not read the history carefully enough. I will address or submit a PR to revert this tomorrow. |
awesome, thanks 👍 |
@shashachu @romtsn I have it solved on my local machine. Code however is not production ready yet. Will continue tomorrow. |
@romtsn @shashachu See #1322 for fix. |
Description
Forces the BY keyword in a super type call entry to be indented when preceded by a new line
The code sample from issue #1210 is now formatted as:
As a side effect, this also formats
to
Closes #1210
Checklist
CHANGELOG.md
is updated