Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager/deploy: do not allow deploying of empty topology #994

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #783

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    图片

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release notes:

fix: not allowing empty topology file for deploy

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. type/bug-fix Categorizes PR as a bug-fix labels Dec 16, 2020
@AstroProfundis AstroProfundis self-assigned this Dec 16, 2020
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2020
@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #994 (9019f26) into master (87f670b) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   55.55%   55.56%   +0.01%     
==========================================
  Files         279      279              
  Lines       19719    19727       +8     
==========================================
+ Hits        10954    10962       +8     
  Misses       7054     7054              
  Partials     1711     1711              
Flag Coverage Δ
cluster 43.46% <75.00%> (+0.02%) ⬆️
dm 23.87% <75.00%> (+0.02%) ⬆️
integrate 49.83% <75.00%> (+0.02%) ⬆️
playground 20.28% <ø> (ø)
tiup 16.46% <ø> (ø)
unittest 23.03% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/deploy.go 70.35% <75.00%> (+0.19%) ⬆️
pkg/cluster/api/pdapi.go 61.30% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1557d4a...5bdd4f1. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2020
@lucklove
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 9019f26

@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR has out-of-dated and I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit 295ade4 into pingcap:master Dec 17, 2020
@AstroProfundis AstroProfundis deleted the empty-deploy branch January 19, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when topology.yaml is empty, 'tiup dm deploy' command should return a error or info to indicate this
4 participants