Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when topology.yaml is empty, 'tiup dm deploy' command should return a error or info to indicate this #783

Closed
seiya-annie opened this issue Sep 14, 2020 · 0 comments · Fixed by #994
Assignees
Labels
type/bug Categorizes issue as related to a bug.
Milestone

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    [root@localhost ~]# tiup dm deploy localhost v3.0 aaa.yaml
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm deploy localhost v3.0 aaa.yaml
    Please confirm your topology:
    dm Cluster: localhost
    dm Version: v3.0
    Type Host Ports OS/Arch Directories

Attention:
1. If the topology is not what you expected, check your yaml file.
2. Please confirm there is no port/directory conflicts in same host.
Do you want to continue? [y/N]: y

  • Generate SSH keys ... Done
  • Download TiDB components
  • Initialize target host environments
  • Copy files
    Deployed cluster localhost successfully, you can start the cluster via tiup dm start localhost
    [root@localhost ~]# tiup dm start localhost
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm start localhost
    Starting cluster localhost...
  • [ Serial ] - SSHKeySet: privateKey=/root/.tiup/storage/dm/clusters/localhost/ssh/id_rsa, publicKey=/root/.tiup/storage/dm/clusters/localhost/ssh/id_rsa.pub
  • [ Serial ] - StartCluster
    Started cluster localhost successfully
    [root@localhost ~]#
    [root@localhost ~]# ls -ltr aaa.yaml
    -rw-r--r--. 1 root root 0 9月 14 10:20 aaa.yaml
  1. What did you expect to see?

an info or error message returned

  1. What did you see instead?

both deploy and start command execute successfully

  1. What version of TiUP are you using (tiup --version)?
    [root@localhost ~]# tiup dm -v
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm -v
    tiup version v1.1.2 tiup
    Go Version: go1.13
    Git Branch: release-1.1
    GitHash: 7cb85b9-dirty
    [root@localhost ~]#
@seiya-annie seiya-annie added the type/bug Categorizes issue as related to a bug. label Sep 14, 2020
@lonng lonng added the status/TODO Categorizes issue as we will do it. label Sep 15, 2020
@lucklove lucklove added this to the v1.3.1 milestone Oct 19, 2020
@AstroProfundis AstroProfundis self-assigned this Dec 10, 2020
@AstroProfundis AstroProfundis removed the status/TODO Categorizes issue as we will do it. label Dec 16, 2020
@lucklove lucklove modified the milestones: v1.3.1, v1.3.0 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants