Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add log dir #908

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Feature/add log dir #908

merged 5 commits into from
Nov 17, 2020

Conversation

9547
Copy link
Contributor

@9547 9547 commented Nov 16, 2020

What problem does this PR solve?

fix #897

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Add `$TIUP_LOG_PATH` to store log file

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #908 (827edaf) into master (f9591eb) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   53.17%   53.14%   -0.03%     
==========================================
  Files         260      260              
  Lines       18909    18911       +2     
==========================================
- Hits        10055    10051       -4     
- Misses       7317     7327      +10     
+ Partials     1537     1533       -4     
Flag Coverage Δ
cluster 45.17% <0.00%> (-0.05%) ⬇️
dm 25.12% <0.00%> (+0.06%) ⬆️
integrate 47.73% <0.00%> (-0.03%) ⬇️
playground 22.17% <ø> (ø)
tiup 10.70% <ø> (ø)
unittest 21.52% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/env.go 92.30% <ø> (ø)
components/cluster/command/root.go 45.50% <0.00%> (ø)
components/dm/command/root.go 54.54% <0.00%> (ø)
pkg/logger/debug.go 16.66% <0.00%> (-2.09%) ⬇️
pkg/utils/retry.go 42.10% <0.00%> (-15.79%) ⬇️
pkg/cluster/spec/tikv.go 55.94% <0.00%> (-1.49%) ⬇️
pkg/cluster/api/pdapi.go 61.60% <0.00%> (+0.92%) ⬆️
pkg/cluster/api/dmapi.go 60.00% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9591eb...827edaf. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2020
@lucklove lucklove merged commit ffa217f into pingcap:master Nov 17, 2020
@9547 9547 deleted the feature/add-log-dir branch April 6, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP logs 随执行命令所在目录生成
5 participants