Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiUP logs 随执行命令所在目录生成 #897

Closed
buggithubs opened this issue Nov 10, 2020 · 5 comments · Fixed by #908
Closed

TiUP logs 随执行命令所在目录生成 #897

buggithubs opened this issue Nov 10, 2020 · 5 comments · Fixed by #908
Labels
status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.

Comments

@buggithubs
Copy link

Feature Request

目前 TiUP logs 随执行命令所在目录生成;
在任意目录执行 TiUP 操作失败后,当前目录会生成 logs 文件夹。
是否可优化成固定路径 logs 目录?

@buggithubs buggithubs added the type/feature-request Categorizes issue as related to a new feature. label Nov 10, 2020
@liangyuanpeng
Copy link

It sounds pretty good.

@9547
Copy link
Contributor

9547 commented Nov 12, 2020

Sounds good, prefer to ${TIUP_HOME}/logs

@lucklove
Copy link
Member

Sounds good, prefer to ${TIUP_HOME}/logs

Prefer ${TIUP_HOME}/storage/cluster/clusters//logs, so that it will be cleanup after the cluster destroyed.

@lucklove lucklove added the status/TODO Categorizes issue as we will do it. label Nov 12, 2020
@liangyuanpeng
Copy link

Sounds good, prefer to ${TIUP_HOME}/logs

Prefer ${TIUP_HOME}/storage/cluster/clusters//logs, so that it will be cleanup after the cluster destroyed.

But the log maybe not about cluster, so i just agree with ${TIUP_HOME}/logs

@lucklove
Copy link
Member

lucklove commented Nov 13, 2020

Sounds good, prefer to ${TIUP_HOME}/logs

Prefer ${TIUP_HOME}/storage/cluster/clusters//logs, so that it will be cleanup after the cluster destroyed.

But the log maybe not about cluster, so i just agree with ${TIUP_HOME}/logs

You and @9547 are right. I didn't think about this:

tiup cluster no-this-command

This will leave a log too, but it's not related to any cluster, so ${TIUP_HOME}/logs is better. But since the log file is write by the cluster component, what about ${TIUP_HOME}/storage/cluster/logs?

The ${TIUP_HOME}/logs should be reserved for TiUP itself, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants