-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tikv label check #800
Conversation
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 48.65% 52.73% +4.07%
==========================================
Files 262 262
Lines 18850 18958 +108
==========================================
+ Hits 9172 9998 +826
+ Misses 8221 7403 -818
- Partials 1457 1557 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Lonng <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@lucklove merge failed. |
What problem does this PR solve?
Check if tikv's label is set correctly: fix #787
What is changed and how it works?
Check List
Tests
Deploy
If both TiKV labels and PD labels not set:
If TiVK labels are set but PD's not:
Display
If both TiKV labels and PD labels not set:
If TiVK labels are set but PD's not:
In this case, TiKV will refuse to start
ScaleOut
The result is the same with deploy
Side effects
Related changes
Release notes: