Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host label at deploy stage by default #787

Closed
Win-Man opened this issue Sep 17, 2020 · 0 comments · Fixed by #800
Closed

Add host label at deploy stage by default #787

Win-Man opened this issue Sep 17, 2020 · 0 comments · Fixed by #800
Labels
priority/P1 Indicates that the priority of a issue is high. status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Milestone

Comments

@Win-Man
Copy link
Contributor

Win-Man commented Sep 17, 2020

Feature Request

Is your feature request related to a problem? Please describe:

I deployed a cluster which had 2 tikv instances on one server and didn't add the label config. Then one of the servers crashed. It result some regions can't access and may be some data lost.

Describe the feature you'd like:

I suggest tiup could add host label config when deploy a cluster. It's better to add an options like --no-lables to decide not to add host label config. --no-lables should be false by default.

But there are still some scenarios need to be considered:

  • If user config the labels in topology.yaml, tiup should use the user's config.
  • If user upgrade from previous version, It should add lables or not.

Describe alternatives you've considered:

Alert a warning message if users deploy a cluster which has more than 2 instances on one server and don't add lables config.

Teachability, Documentation, Adoption, Migration Strategy:

@Win-Man Win-Man added the type/feature-request Categorizes issue as related to a new feature. label Sep 17, 2020
@lucklove lucklove added this to the v1.2.0 milestone Sep 17, 2020
@lucklove lucklove added status/TODO Categorizes issue as we will do it. priority/P1 Indicates that the priority of a issue is high. labels Sep 17, 2020
@lucklove lucklove mentioned this issue Sep 22, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 Indicates that the priority of a issue is high. status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants