Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: TiUP Cluster UI #706
DNM: TiUP Cluster UI #706
Changes from 25 commits
c33c6a2
331db68
e293bcc
4bba02f
22909d6
1d0af1f
e8698b0
e3325df
3be76e2
247f532
2448965
79dd983
48325fa
ad54704
99dd507
886306f
f6bd841
daf6b10
94f4c19
1988e58
29b1875
1742586
bdf27ef
00d770f
5e011c1
5b86dd7
9ce7594
2dce800
89d74e1
263e30c
6e981e7
ce5e697
d95335f
457f487
43cb6b5
6c6bd5a
7042039
23f072e
75a6f18
aed394d
9a92132
541e1cd
7896fdc
820bd3e
023518e
d592948
299c066
d3ad4f1
7000f93
cee5dcc
6a5400a
c356c8b
18b657c
2cb3203
9394152
4460b5d
d2a09cb
fcbfc51
8cfce30
b9a36ca
76b3d3c
2c2499a
810920f
2e54aba
833de2e
d2fe18f
bc86612
ff62f32
11d3ab9
d4ee68d
7a3a493
f26acef
eb126d1
4b0baa9
cee57a4
201ae0b
f9c0219
01149df
17137cd
8bd384f
615e57b
fe2b3b6
bc05c60
dbe5688
af4b9e0
c7c2e98
960d9a1
af8b247
9429443
0764786
f010f10
c3b82a1
aa746c4
5af2a18
ee6ea25
e713d2e
d9eb614
0f5e2e3
066a2a0
5231734
68ea2f7
1d8b1e8
62f136e
13c7418
31900e3
a2749d0
fd4a164
1589547
42b82b8
7dc97c9
d57d330
c2864ab
d334a3a
ab47793
f82a768
ea0a9f4
d4fdb0c
eb717c7
539c434
0e93281
d5d90d2
2c7a95d
6fc3ad6
d57a6ff
5aed034
33550f9
b71c7bb
a6422ae
26b6c71
ef8cf3a
03165c7
5c6b6c0
ffa34e7
6520a29
89f4c98
a3a4c17
660054c
ce6490f
29975d3
7f75414
0fc71b9
54545a1
bb5a48a
83e22f9
b456ce1
307be0b
27e1bca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to use a user defined path, like
-i
incluster
'sdeploy
sub commandThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These timeout arguments should also be defined by the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the frontend has no setting page to set these options, so I simply use the default values. Maybe we can add a setting page later (depends on the requirement).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choosing SSH implementation is also needed by some environments of users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should honor the user's SSH implementation choice as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer reusing the
docker/up.sh
utilities to use docker-compose instead of introducing vagrant to the repo. Or even better, we find some way to make the tests independent from any virtualization.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directory name should be lower case. e.g:
manual-test-env