Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: TiUP Cluster UI #706

Closed
wants to merge 147 commits into from
Closed

DNM: TiUP Cluster UI #706

wants to merge 147 commits into from

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Aug 22, 2020

What problem does this PR solve?

Supply a web UI of tiup cluster component for user to easily deploy and operate a cluster.

企业微信20200911102334

企业微信20200911102937

What is changed and how it works?

Add a web UI that includes both backend and frontend.

Compile it by:

$ make embed_cluster_ui
$ UI=1 make

Run it by:

$ bin/tiup-cluster --ui

Access http://ip:8080 in the browser.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Increased code complexity

Related changes

  • Need to update the documentation

Release notes:

- Supply a web UI of tiup cluster component for user to easily deploy and operate a cluster.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2020

CLA assistant check
All committers have signed the CLA.

@baurine baurine marked this pull request as draft August 22, 2020 08:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2020

Codecov Report

Merging #706 into master will increase coverage by 2.36%.
The diff coverage is 20.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   51.47%   53.84%   +2.36%     
==========================================
  Files         249      263      +14     
  Lines       20676    21575     +899     
==========================================
+ Hits        10644    11617     +973     
+ Misses       8622     8393     -229     
- Partials     1410     1565     +155     
Flag Coverage Δ
#cluster 46.09% <20.35%> (-0.75%) ⬇️
#dm 27.03% <39.54%> (+0.12%) ⬆️
#integrate 49.22% <20.56%> (-0.11%) ⬇️
#playground 22.96% <ø> (?)
#tiup 11.28% <0.00%> (-0.01%) ⬇️
#unittest 19.26% <0.91%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/check.go 79.73% <0.00%> (ø)
components/cluster/web/uiserver/uiserver.go 0.00% <0.00%> (ø)
components/cluster/web/web.go 0.00% <0.00%> (ø)
pkg/cliutil/ssh.go 19.56% <9.09%> (-1.49%) ⬇️
components/cluster/command/root.go 44.02% <25.00%> (-0.87%) ⬇️
pkg/cluster/task/task.go 62.63% <31.25%> (-11.25%) ⬇️
pkg/cluster/manager.go 65.18% <44.66%> (-2.50%) ⬇️
pkg/cluster/task/step.go 78.57% <81.81%> (+0.16%) ⬆️
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169e7cb...ea0a9f4. Read the comment docs.

@baurine
Copy link
Contributor Author

baurine commented Aug 22, 2020

Current Progress:

  • Enable add/edit/remove machines and components
  • Enable deploy a cluster and view its progress
  • Enable show a deployed cluster topo and information
  • Enable destroy a cluster

企业微信20200822073044

企业微信20200822074024


企业微信20200822073816


企业微信20200822073935


企业微信20200822074045

企业微信20200822074013

@breeswish @lonng

@lonng
Copy link
Contributor

lonng commented Aug 23, 2020

@baurine Awesome

@ti-chi-bot
Copy link
Member

@baurine: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2020
@AstroProfundis
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020
@baurine
Copy link
Contributor Author

baurine commented Feb 19, 2021

The upstream changes too much so will abandon this PR, and commit a new PR that base on the latest master branch.

@baurine
Copy link
Contributor Author

baurine commented Mar 2, 2021

Replace it with #1172

@baurine baurine closed this Mar 2, 2021
@baurine baurine deleted the tiup-web branch March 2, 2021 10:00
@baurine baurine restored the tiup-web branch March 2, 2021 10:00
@baurine baurine deleted the tiup-web branch April 3, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants