Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: print more clear warning when scale in with --force #1477

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1453

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis requested a review from lucklove July 8, 2021 08:34
@AstroProfundis AstroProfundis self-assigned this Jul 8, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
@AstroProfundis AstroProfundis added this to the v1.5.3 milestone Jul 8, 2021
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9f44afc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1477 (89dedd5) into master (35998e0) will increase coverage by 6.28%.
The diff coverage is 33.33%.

❗ Current head 89dedd5 differs from pull request most recent head 4ff240f. Consider uploading reports for the commit 4ff240f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   26.27%   32.56%   +6.28%     
==========================================
  Files         267      228      -39     
  Lines       23784    20745    -3039     
==========================================
+ Hits         6249     6755     +506     
+ Misses      16714    12961    -3753     
- Partials      821     1029     +208     
Flag Coverage Δ
cluster 32.56% <33.33%> (?)
integrate 32.56% <33.33%> (+16.39%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/scale_in.go 51.92% <33.33%> (+51.92%) ⬆️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-83.15%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/utils/semver.go 5.51% <0.00%> (-81.11%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-77.78%) ⬇️
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35998e0...4ff240f. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 09c49be into pingcap:master Jul 14, 2021
@AstroProfundis AstroProfundis deleted the warn-force-scalein branch July 14, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display should show the exact store state after executing scale in --force
4 participants