Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display should show the exact store state after executing scale in --force #1453

Closed
rleungx opened this issue Jun 25, 2021 · 2 comments · Fixed by #1477
Closed

Display should show the exact store state after executing scale in --force #1453

rleungx opened this issue Jun 25, 2021 · 2 comments · Fixed by #1477
Labels
type/bug Categorizes issue as related to a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jun 25, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

Run scale in --force for a TiKV

  1. What did you expect to see?

Show the real store state of that TiKV.

  1. What did you see instead?

The TiKV disappears in the display list which may mislead the user to do some dangerous operation like clean up the store data. It will cause the unavailable of some regions.
Or we should warn users to prevent using --force AMAP.

  1. What version of TiUP are you using (tiup --version)?

master

@rleungx rleungx added the type/bug Categorizes issue as related to a bug. label Jun 25, 2021
@breezewish
Copy link
Member

Another problem seems to be "--force" can be very unsafe.

@AstroProfundis
Copy link
Contributor

--force IS very unsafe, I think we could add a warning for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants