Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments all lines from files in ansible-imported-configs after import from ansible #1350

Merged
merged 4 commits into from
May 10, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented May 7, 2021

Implement #1347

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from AstroProfundis and lonng May 7, 2021 08:23
@lucklove lucklove added the ansible Categorizes issue as related to tidb-ansible label May 7, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2021
@lucklove lucklove added this to the v1.5.0 milestone May 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #1350 (e735735) into master (6ee8abc) will decrease coverage by 9.43%.
The diff coverage is n/a.

❗ Current head e735735 differs from pull request most recent head 3c9aa3c. Consider uploading reports for the commit 3c9aa3c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
- Coverage   25.44%   16.00%   -9.44%     
==========================================
  Files         265      148     -117     
  Lines       20412    12468    -7944     
==========================================
- Hits         5193     1995    -3198     
+ Misses      14422     9967    -4455     
+ Partials      797      506     -291     
Flag Coverage Δ
integrate 16.00% <ø> (+0.47%) ⬆️
tiup 16.00% <ø> (+0.47%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
embed/embed.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/spec/validate.go 0.00% <0.00%> (-90.70%) ⬇️
pkg/utils/semver.go 2.60% <0.00%> (-82.61%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-82.50%) ⬇️
pkg/cluster/executor/checkpoint.go 0.00% <0.00%> (-82.23%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/cluster/spec/parse_topology.go 0.00% <0.00%> (-78.47%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-73.34%) ⬇️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee8abc...3c9aa3c. Read the comment docs.

pkg/cluster/ansible/import.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e735735

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 073b8a9 into pingcap:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Categorizes issue as related to tidb-ansible size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants