Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments all lines from files in ansible-imported-configs after import from ansible #1347

Closed
lucklove opened this issue May 6, 2021 · 0 comments
Labels
type/feature-request Categorizes issue as related to a new feature.
Milestone

Comments

@lucklove
Copy link
Member

lucklove commented May 6, 2021

Feature Request

Is your feature request related to a problem? Please describe:

https://asktug.com/t/topic/69833

Describe the feature you'd like:

After copying configs from ansible-imported-configs to meta.yaml, we should comments all lines in ansible-imported-configs.

Why the featue is needed:

It's a normal demand that the user may delete some configs from meta.yaml via tiup cluster edit-config, however, for imported configs, there is another copy in ansible-imported-configs so that the deleting action won't work unless deleting configs from ansible-imported-configs too because we will merge configs from ansible-imported-configs.
So after copying ansible-imported-configs to meta.yaml, we should comments all lines in ansible-imported-configs, by this way, there is only one copy of that config.
We can't delete ansible-imported-configs directly because we should keep the merging behavior for old clusters whose ansible-imported-configs wasn't copyed into meta.yaml.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@lucklove lucklove added the type/feature-request Categorizes issue as related to a new feature. label May 6, 2021
@lucklove lucklove added this to the v1.5.0 milestone May 6, 2021
lucklove added a commit to lucklove/tiup that referenced this issue May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants