Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo with find command #1256

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Fix typo with find command #1256

merged 2 commits into from
Mar 29, 2021

Conversation

rkazak
Copy link
Contributor

@rkazak rkazak commented Mar 27, 2021

Fix typo for find command.

What problem does this PR solve?

When running make we see

rkazak@rkazaknb tiup % make
gofmt (simplify)
goimports (if installed)
linting
./tools/check/check-lint.sh
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
go mod tidy

What is changed and how it works?

Added in missing '.' - local dir path.

rkazak@rkazaknb tiup % make        
gofmt (simplify)
goimports (if installed)
linting
./tools/check/check-lint.sh
go mod tidy

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Fix typo for find command.
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from breezewish March 27, 2021 19:31
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2021
@codecov-io
Copy link

codecov-io commented Mar 27, 2021

Codecov Report

Merging #1256 (a2b59de) into master (1225c01) will decrease coverage by 23.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1256       +/-   ##
===========================================
- Coverage   49.80%   26.49%   -23.32%     
===========================================
  Files         289      275       -14     
  Lines       20642    19120     -1522     
===========================================
- Hits        10280     5065     -5215     
- Misses       8706    13284     +4578     
+ Partials     1656      771      -885     
Flag Coverage Δ
cluster ?
dm ?
integrate 15.93% <ø> (-27.81%) ⬇️
playground 3.09% <ø> (ø)
tiup 16.39% <ø> (ø)
unittest 22.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/meta/paths.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/utils.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/logger/log/log.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/task/builder.go 0.00% <0.00%> (-91.84%) ⬇️
pkg/cluster/ctxt/context.go 0.00% <0.00%> (-89.10%) ⬇️
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1225c01...a2b59de. Read the comment docs.

@rkazak
Copy link
Contributor Author

rkazak commented Mar 27, 2021

/cc @Reviewer

@ti-chi-bot
Copy link
Member

@rkazak: GitHub didn't allow me to request PR reviews from the following users: reviewer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Reviewer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@lucklove
Copy link
Member

lucklove commented Mar 29, 2021

Thank you @rkazak

@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7068cc2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 09c186a into pingcap:master Mar 29, 2021
AstroProfundis pushed a commit that referenced this pull request Mar 30, 2021
@lucklove lucklove added this to the v1.4.0 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants