Merge branch 'master' into patch-1

pingcap · Mar 29, 2021 · 7068cc2 · 7068cc2
2 parents a2b59de + da012e4
commit 7068cc2
Show file tree

Hide file tree

Showing 29 changed files with 450 additions and 131 deletions.
diff --git a/components/cluster/command/display.go b/components/cluster/command/display.go
@@ -80,6 +80,7 @@ func newDisplayCmd() *cobra.Command {
 
 	cmd.Flags().StringSliceVarP(&gOpt.Roles, "role", "R", nil, "Only display specified roles")
 	cmd.Flags().StringSliceVarP(&gOpt.Nodes, "node", "N", nil, "Only display specified nodes")
+	cmd.Flags().BoolVar(&gOpt.ShowUptime, "uptime", false, "Display with uptime")
 	cmd.Flags().BoolVar(&showDashboardOnly, "dashboard", false, "Only display TiDB Dashboard information")
 	cmd.Flags().BoolVar(&showVersionOnly, "version", false, "Only display TiDB cluster version")
 

diff --git a/components/dm/command/display.go b/components/dm/command/display.go
@@ -54,6 +54,7 @@ func newDisplayCmd() *cobra.Command {
 	cmd.Flags().StringSliceVarP(&gOpt.Roles, "role", "R", nil, "Only display specified roles")
 	cmd.Flags().StringSliceVarP(&gOpt.Nodes, "node", "N", nil, "Only display specified nodes")
 	cmd.Flags().BoolVar(&showVersionOnly, "version", false, "Only display DM cluster version")
+	cmd.Flags().BoolVar(&gOpt.ShowUptime, "uptime", false, "Display DM with uptime")
 
 	return cmd
 }
diff --git a/components/dm/spec/bindversion.go b/components/dm/spec/bindversion.go
@@ -8,7 +8,9 @@ func DMComponentVersion(comp, version string) string {
 	switch comp {
 	case spec.ComponentAlertmanager,
 		spec.ComponentGrafana,
-		spec.ComponentPrometheus:
+		spec.ComponentPrometheus,
+		spec.ComponentBlackboxExporter,
+		spec.ComponentNodeExporter:
 		return ""
 	default:
 		return version

diff --git a/components/dm/spec/logic.go b/components/dm/spec/logic.go
@@ -15,9 +15,11 @@ package spec
 
 import (
 	"context"
+	"crypto/tls"
 	"fmt"
 	"path/filepath"
 	"strings"
+	"time"
 
 	"github.com/pingcap/tiup/pkg/logger/log"
 	"github.com/pingcap/tiup/pkg/meta"
@@ -88,6 +90,9 @@ func (c *DMMasterComponent) Instances() []Instance {
 					s.DataDir,
 				},
 				StatusFn: s.Status,
+				UptimeFn: func(tlsCfg *tls.Config) time.Duration {
+					return spec.UptimeByHost(s.Host, s.Port, tlsCfg)
+				},
 			},
 			topo: c.Topology,
 		})
@@ -216,6 +221,9 @@ func (c *DMWorkerComponent) Instances() []Instance {
 					s.DataDir,
 				},
 				StatusFn: s.Status,
+				UptimeFn: func(tlsCfg *tls.Config) time.Duration {
+					return spec.UptimeByHost(s.Host, s.Port, tlsCfg)
+				},
 			},
 			topo: c.Topology,
 		})
@@ -294,7 +302,7 @@ func (topo *Specification) GetGlobalOptions() spec.GlobalOptions {
 
 // GetMonitoredOptions returns MonitoredOptions
 func (topo *Specification) GetMonitoredOptions() *spec.MonitoredOptions {
-	return nil
+	return topo.MonitoredOptions
 }
 
 // ComponentsByStopOrder return component in the order need to stop.