-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tiup supports define root_url and enable anonymous in grafana.ini #1085
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 56.56% 55.42% -1.15%
==========================================
Files 283 283
Lines 20016 20025 +9
==========================================
- Hits 11323 11098 -225
- Misses 6937 7207 +270
+ Partials 1756 1720 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In https://grafana.com/tutorials/run-grafana-behind-a-proxy/#1 It says:
And the final example is like:
So I think maybe you forget to set the domain (by default, it's the IP address). I suggest that you can add a |
OK,I add domain field parsed from domain if root_url is set or not cause someone may only set domain. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0d46b5e
|
…i to run a reverse proxy add domain config of grafana.ini use tiup
@mianhk: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
fix: #849
What is changed and how it works?
reference: https://grafana.com/tutorials/run-grafana-behind-a-proxy/#1
Check List
Tests
Then, you can get a grafana.ini like:
Code changes
Side effects
Related changes
Release notes: