Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup supports config.ini for configuring grafana and prometheus #849

Closed
sultan8252 opened this issue Oct 19, 2020 · 4 comments · Fixed by #1085
Closed

tiup supports config.ini for configuring grafana and prometheus #849

sultan8252 opened this issue Oct 19, 2020 · 4 comments · Fixed by #1085
Labels
status/discuss Indicates that the issue is in discussion, if no reply for long time, the issue will be closed. type/feature-request Categorizes issue as related to a new feature.

Comments

@sultan8252
Copy link

Feature Request

Is your feature request related to a problem? Please describe:
Manually adjust the grafana related configuration after each reload operation or cluster upgrade. Similar problems and prometheus

Describe the feature you'd like:
The configuration in config.ini related to grafana and prometheus is supported in tiup.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@sultan8252 sultan8252 added the type/feature-request Categorizes issue as related to a new feature. label Oct 19, 2020
@lucklove lucklove added the status/discuss Indicates that the issue is in discussion, if no reply for long time, the issue will be closed. label Oct 19, 2020
@lucklove
Copy link
Member

Dose this help on this issue?

@sultan8252
Copy link
Author

The grafana address is accessed through the nginx reverse proxy and needs to be manually specified after each reload

@lucklove
Copy link
Member

The grafana address is accessed through the nginx reverse proxy and needs to be manually specified after each reload

So do you want to config the domain filed in topology file?

@mianhk
Copy link
Contributor

mianhk commented Jan 21, 2021

Configuring Grafana to run behind a reverse proxy need root_url defined refrenced to : https://grafana.com/tutorials/run-grafana-behind-a-proxy/#1
But now when we use reload/scale-in/scale-out command ，the grafana.ini will be refreshed and need to be edit manually.

This was referenced Jan 21, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/discuss Indicates that the issue is in discussion, if no reply for long time, the issue will be closed. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@lucklove @sultan8252 @mianhk