Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the node_exporter instance of the server where the tiflash-server… #1083

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Add the node_exporter instance of the server where the tiflash-server… #1083

merged 1 commit into from
Jan 20, 2021

Conversation

yuzhibotao
Copy link
Contributor

… is located to prometheus.yml

What problem does this PR solve?

There is no system monitoring configuration of the server where tiflash-server is located in the prometheus.yml

What is changed and how it works?

Add the server where tiflash-server is located to the monitored host list.

Check List

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from july2993 January 20, 2021 09:08
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2021
@lucklove
Copy link
Member

Fix #1081

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2021
@lucklove
Copy link
Member

Close #1081

@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a96ff04

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2021
@ti-chi-bot ti-chi-bot merged commit d4881ba into pingcap:master Jan 20, 2021
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 21, 2021
@yuzhibotao
Add the node_exporter instance of the server where the tiflash-server…
10c6d96 
… is located to prometheus.yml (pingcap#1083)
@lucklove lucklove added this to the v1.4.0 milestone Mar 24, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.4.0, v1.3.7 Mar 24, 2021
@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Mar 24, 2021
AstroProfundis pushed a commit that referenced this pull request Mar 24, 2021
@yuzhibotao @AstroProfundis
Add the node_exporter instance of the server where the tiflash-server…
137363a 
… is located to prometheus.yml (#1083)
@flowbehappy flowbehappy mentioned this pull request Apr 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 Awaiting requested review from july2993

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Milestone
v1.3.7
Development

Successfully merging this pull request may close these issues.
4 participants
@yuzhibotao @lucklove @ti-chi-bot @AstroProfundis