Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize TiKV --advertise-status-addr #892

Closed
breezewish opened this issue Nov 9, 2020 · 1 comment · Fixed by #951
Closed

Utilize TiKV --advertise-status-addr #892

breezewish opened this issue Nov 9, 2020 · 1 comment · Fixed by #951
Labels
status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Milestone
v1.3.0

Comments

@breezewish
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe:

Now --advertise-status-addr is not set, so that TiKV reports a wrong advertise address (which comes from --status-addr) when --status-addr is set to a wildcard address like 0.0.0.0.

Describe the feature you'd like:

For TiKV >= 4.0.1, add --advertise-status-addr parameter.

Describe alternatives you've considered:

As an alternative, TiKV can infer a correct advertise status address from advertise address. However I have no idea why it is not considered in the original proposal.

Teachability, Documentation, Adoption, Migration Strategy:
@breezewish breezewish added the type/feature-request Categorizes issue as related to a new feature. label Nov 9, 2020
@lucklove lucklove added the status/TODO Categorizes issue as we will do it. label Nov 9, 2020
@lucklove
Copy link
Member

lucklove commented Nov 9, 2020

Related change: tikv/tikv#7920

@breezewish breezewish mentioned this issue Nov 9, 2020
Merged
@lucklove lucklove added this to the v1.2.5 milestone Nov 19, 2020
@lucklove lucklove modified the milestones: v1.2.5, v1.2.6 Nov 30, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Nov 30, 2020
@lucklove
Utilize TiKV --advertise-status-addr
8d6d084 
Fix pingcap#892
@lucklove lucklove mentioned this issue Nov 30, 2020
Merged
lucklove added a commit that referenced this issue Dec 3, 2020
@lucklove
Utilize TiKV --advertise-status-addr (#951)
a290d33 
Fix #892
@lucklove lucklove modified the milestones: v1.2.6, v1.3.0 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/TODO Categorizes issue as we will do it. type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Utilize TiKV --advertise-status-addr lucklove/tiup
2 participants
@breezewish @lucklove