-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: resolve loopback address of node (#20546) #20850
infoschema: resolve loopback address of node (#20546) #20850
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@crazycs520 Please resolve the conflict. |
Signed-off-by: crazycs520 <[email protected]>
/run-all-tests |
/run-sqllogic-test-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/merge |
Sorry @winoros, this branch cannot be merged without an approval of release maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/run-unit-test
/merge |
Sorry @tiancaiamao, this branch cannot be merged without an approval of release maintainers |
/merge |
Sorry @bb7133, this branch cannot be merged without an approval of release maintainers |
/merge |
/run-all-tests |
cherry-pick #20546 to release-4.0
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
fix #20528
When Using
tiup
to deploy a TiDB cluster, the ip ofTiKV
status-address
is0.0.0.0
. then query thecluster_config
system will return error.What is changed and how it works?
Normally, start tikv with specified
advertise-status-addr
parameter will be ok, butadvertise-status-addr
doesn't exist before tikv/tikv#7944, soTiUP
can't specify theadvertise-status-addr
by default.So, I have to fix this in TiDB. In this PR:
Related changes
Check List
Tests
Side effects
Release note