Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vitess_hash function code to tipb #198

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

bezmax
Copy link
Contributor

@bezmax bezmax commented Nov 11, 2020

What problem does this PR solve?

Issue Number: pingcap/tidb#20971

Problem Summary: Implementing vitess_hash function to support efficient migration between tidb <-> vitess.

What is changed and how it works?

Proposal: pingcap/tidb#20971

What's Changed: New builtin_misc function added implementing vitess_hash algorithm.

Related changes

In order PRs need to be merged:

  1. (This PR) Adding vitess_hash function code to tipb #198
  2. Adding vitess_hash function to ast parser#1089
  3. expression: Implementation of Vitess hashing algorithm. tidb#23493

Release note

Added vitess_hash function which implements Vitess' hashing algorithm to determine sharding key.

@bezmax bezmax changed the title Adding vitess_hash function code Draft: Adding vitess_hash function code Nov 11, 2020
@bezmax bezmax force-pushed the bezmax-vitess-hash branch from 4c34ee3 to e1d9ed9 Compare November 11, 2020 01:42
@bezmax bezmax changed the title Draft: Adding vitess_hash function code Adding vitess_hash function code to tipb Nov 12, 2020
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent
Copy link
Contributor

/cc @qw4990

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2020

CLA assistant check
All committers have signed the CLA.

@Reminiscent
Copy link
Contributor

@qw4990 PTAL

@bezmax bezmax force-pushed the bezmax-vitess-hash branch from 79bfb2c to 9a5efa9 Compare March 23, 2021 20:22
@morgo morgo requested review from qw4990 and windtalker March 25, 2021 15:19
@windtalker
Copy link
Contributor

/lgtm

@bb7133
Copy link
Member

bb7133 commented Mar 26, 2021

/LGTM

Copy link

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@morgo morgo merged commit 1164ca0 into pingcap:master Mar 26, 2021
@zz-jason
Copy link
Member

it's weird that no rust code is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants