Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Implementation of Vitess hashing algorithm. (#23493) #23915

Merged
merged 1 commit into from
Apr 8, 2021
Merged

expression: Implementation of Vitess hashing algorithm. (#23493) #23915

merged 1 commit into from
Apr 8, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 8, 2021 •
edited
Loading

cherry-pick #23493 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23915

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/23915:release-5.0-f97496d0fc89

What problem does this PR solve?

Issue Number: close #20971

Problem Summary: Implementing vitess_hash function to support efficient migration between tidb <-> vitess.

What is changed and how it works?

Proposal: #20971

What's Changed: New builtin_misc function added implementing vitess_hash algorithm.

Related changes

In order PRs need to be merged:

  1. Adding vitess_hash function code to tipb tipb#198
  2. Adding vitess_hash function to ast parser#1089
  3. (This PR) expression: Implementation of Vitess hashing algorithm. #23493

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Added vitess_hash function which implements Vitess' hashing algorithm to determine sharding key.

@ti-srebot ti-srebot requested a review from a team as a code owner April 8, 2021 01:58
@ti-srebot ti-srebot requested review from wshwsh12 and removed request for a team April 8, 2021 01:58
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Apr 8, 2021
Merged
@ti-srebot ti-srebot added component/config component/expression first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.0-cherry-pick labels Apr 8, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Apr 8, 2021
@ti-srebot
Copy link
Contributor Author

@bezmax please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 8, 2021
zz-jason
zz-jason approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wshwsh12
  • zz-jason

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2021
@zz-jason zz-jason removed request for lzmhhh123 and morgo April 8, 2021 02:22
@zz-jason
Copy link
Member

zz-jason commented Apr 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4896209

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2021
@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit f3951ec into pingcap:release-5.0 Apr 8, 2021
@dveeden dveeden mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/config component/expression first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.0 ga
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @zz-jason @zhouqiang-cl @wshwsh12 @bezmax