Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): use separate ctx for each DML (#7981) #7985

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7981

What problem does this PR solve?

Issue Number: close #7982

What is changed and how it works?

use separate ctx for each DML to avoid the timeout when executing the big Txn.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

Fix the bug that context deadline was exceeded when replicating data without split big txn

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Dec 28, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 28, 2022
@nongfushanquan
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2023
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8298386

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023
@Rustin170506
Copy link
Member

/run-verify

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@f69c799). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 51ae3eb differs from pull request most recent head d4278a3. Consider uploading reports for the commit d4278a3 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 66.9964% <0.0000%> (?)
dm 54.9794% <0.0000%> (?)
engine 66.5053% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #7985   +/-   ##
================================================
  Coverage               ?   62.2369%           
================================================
  Files                  ?        894           
  Lines                  ?     118563           
  Branches               ?          0           
================================================
  Hits                   ?      73790           
  Misses                 ?      38868           
  Partials               ?       5905           

@nongfushanquan
Copy link
Contributor

/run-verify

1 similar comment
@purelind
Copy link
Collaborator

/run-verify

@ti-chi-bot ti-chi-bot merged commit 9613e94 into pingcap:release-6.1 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants