Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): use separate ctx for each DML #7981

Merged
merged 2 commits into from
Dec 28, 2022
Merged

sink(ticdc): use separate ctx for each DML #7981

merged 2 commits into from
Dec 28, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7982

What is changed and how it works?

use separate ctx for each DML to avoid the timeout when executing the big Txn.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

Fix the bug that context deadline was exceeded when replicating data without split big txn

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hicqu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-linked-issue labels Dec 27, 2022
@Rustin170506 Rustin170506 marked this pull request as ready for review December 27, 2022 08:22
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2022
@Rustin170506
Copy link
Member Author

Tested locally:
image

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 27, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 27, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: df02a39

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2022
@ti-chi-bot ti-chi-bot merged commit f71045f into pingcap:master Dec 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7984.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#7981
bd60edf 
Signed-off-by: ti-chi-bot <[email protected]>
@Rustin170506 Rustin170506 added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Dec 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #7985.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#7981
9a75a40 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jan 10, 2023
@ti-chi-bot
sink(ticdc): use separate ctx for each DML (#7981) (#7985)
9613e94 
close #7982
ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
@ti-chi-bot
sink(ticdc): use separate ctx for each DML (#7981) (#7984)
3757a82 
close #7982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context deadline exceeded when replicating data without split big txn
4 participants
@Rustin170506 @ti-chi-bot @amyangfei @hicqu